Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneHot encoding of inputs is potentially incorrect, correction required #29

Open
RMichae1 opened this issue May 14, 2024 · 0 comments
Open

Comments

@RMichae1
Copy link
Collaborator

In the pr/solver.py Line 123 all inputs are one-hot encoded.
However this is incorrect for some problem cases for example discrete categorical inputs.
This leads to a wrong optimization scheme ultimately (and a significantly larger problem space).

TODO: only if absolutely required do torch.nn.functional.one_hot(X_init) otherwise keep input variables (integers) as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant