Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable doubleTapTime set to -1? #122

Open
coofzilla opened this issue Aug 14, 2024 · 4 comments
Open

Disable doubleTapTime set to -1? #122

coofzilla opened this issue Aug 14, 2024 · 4 comments

Comments

@coofzilla
Copy link

right now im setting the doubleTapTime to -1 to "effectively" disable the feature where it goes to fullscreen. In the case where a user is spamming seek and I dont want them to keep toggling between fullscreen and not ( our videos are quite long ).

However, I want to make sure this is an intended feature and should the description be updated to reflect that?

@LunatiqueCoder
Copy link
Owner

Hey @coofzilla. I'm not sure I'm following what's the issue here 🤔

@coofzilla
Copy link
Author

so basically,

Double tapping will toggle fullscreen.

I want to disable that behavior, so I set doubleTapTime to -1.

I’m checking if this is the intended way to disable the feature, or if it's just a workaround that might break if the implementation changes in the future.

The current documentation says:

doubleTapTime: Tapping twice within this amount of time in milliseconds is considered a double tap

It doesn’t explicitly mention that setting it to -1 disables the feature.

I want to ensure I’m not relying on something that could change.

Hopefully thats a bit more clear 😅

@LunatiqueCoder
Copy link
Owner

Oh ok, that's also a good find. I don't remember precisely how it's implemented, but it can definitely be improved.

@coofzilla
Copy link
Author

If this is an intended solution; then, perhaps just a documentation change is all thats needed? I can scope out the internal details later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants