Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo / Redo not working as expected on Strict Mode #279

Open
brauliodiez opened this issue Aug 27, 2024 · 1 comment
Open

Undo / Redo not working as expected on Strict Mode #279

brauliodiez opened this issue Aug 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@brauliodiez
Copy link
Member

We have temporarily disabled strict mode on the main:

./src/main.tsx

ReactDOM.createRoot(document.getElementById('root')!).render(
- <React.StrictMode> 
   <CanvasProvider>
      <ModalDialogProvider>
        <App />
      </ModalDialogProvider>
    </CanvasProvider>
- </React.StrictMode> 

);

Undo Redo does not work well (just add two snapshots), in the following cases:

  • Delete a shape (toolbar click button).
  • Inline edit on a shape an clicking outside.

Further research to be developed

We have just workarounded temporarily

@brauliodiez brauliodiez added the bug Something isn't working label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs definition
Development

No branches or pull requests

2 participants
@brauliodiez and others