-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-30 | Add a simple text based protocol to the project to display continuous measurement results #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KGergo88
added
enhancement
New, or improved functionality
do not merge
This pull request should not be merged
labels
Aug 29, 2020
7 tasks
KGergo88
changed the title
Issue-30 | Add a simple text based protocol to the project to display continuous measurement results
WIP Issue-30 | Add a simple text based protocol to the project to display continuous measurement results
Aug 29, 2020
Force pushed the branch to rebase it onto master. |
KGergo88
added
in progress
The issue is currently being worked on
and removed
in progress
The issue is currently being worked on
labels
Aug 30, 2020
Force pushed the branch to rebase it onto master. |
Details: - Breaking up the DataProcessingInterface to: - ProtocolInterface - DataProcessingInterface - DataExportingInterface - Adding the empty CMDP implementation - Adapting the MDP implementation to the new interfaces
Details: - Adding new methods to the DataLine class - Adding new methods to the Diagram class
Details: - The solving the diamond inheritance problem of the ProtocolInterface - Extending the DataExportingInterface - Updating the MeasurementDataProtocol
Details: - Implementing the regex patterns - Adding the methods required by the interfaces - Starting to implement the statemachine of the ProcessData()
Details: - Turning off optimizations for the Tests in debug build - Adding type definitions for the test_data_line.cpp - Updating the DataLine constructor calls
Details: - The call needed to be updated after the introduction of the DataLine ID - Removed an unused local
Details: - ProtocolInterface --> I_Protocol - Merging the DataExportingInterface and DataProcessingInterface into I_Protocol - Updating the MDP implementation - Updating the CMDP implementation - Updating the NetworkHandler implementation
Details: - Adding tests for the already implemented CMDP methods - Extracting the common parts from the MDP tests that can be used for the CMDP and future protocols and storing them into the test_protocol_common.h - Updating the MDP unit tests
Details: - Adding the cmdp testfiles to QMake file - Switching to Qt regexes in the CMDP - Fixing the CMDP state machine and regex patterns - Adding the missing override for the virtual methods - Reworking the regex pattern definition - Adding a unit test for the TEST_1C_0E_CMDP.cmdp - Adding the TestFileReader to the common protocol test header
Coverage after merging CMDP_#30 into master
Coverage Report
|
Coverage after merging CMDP_#30 into master
Coverage Report
|
5 tasks
Details: - Making the types accessible in DataLine - Making the types accessible in DataPoint - Making the types accessible in Diagram - Removing the DataLineId feature from DataLine - Switching to using OrderedDict as the container in Diagram - Not removing the whitespaces from the data in MDP and CMDP to fix messing up the titles with spaces - Added checks for duplicate DataLine IDs - Added checks for not-existing DataLine IDs - Updating the MDP with DataLine IDs (not used in MDP) - Adding copy and move constructors and operators to OrderedDict - Adding duplicate key check for push_back() and emplace_back() in OrderedDict - Fixing the push_back() signature in OrderedDict - Adding begin() and end() to OrderedDict - Adding new tests for the rest of the CMDP test files - Updating the DataLine unit tests - Updating the OrderedDict unit tests - Removing the #warning directives from the codebase as they break the Windows CI job
Coverage after merging CMDP_#30 into master
Coverage Report
|
3 tasks
KGergo88
changed the title
WIP Issue-30 | Add a simple text based protocol to the project to display continuous measurement results
Issue-30 | Add a simple text based protocol to the project to display continuous measurement results
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30