-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the on_error keyword for parallel execution #452
base: master
Are you sure you want to change the base?
Conversation
This makes sure, that the errors are actually thrown and not hidden.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Pull Request Test Coverage Report for Build 11363376442Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11363376442Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 11363376442Details
💛 - Coveralls |
but now, I wonder, what would be the use case for allowing such thing. |
@@ -708,7 +708,7 @@ function runLoop(dc::DATConfig, showprog) | |||
"YAXArrays is not loaded on all workers. Please run `@everywhere using YAXArrays` to fix.", | |||
) | |||
mapfun = showprog ? progress_pmap : pmap | |||
mapfun(CachingPool(workers()),allRanges, on_error=identity) do r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking that maybe we should pass this as a kwarg to mapfun
via dc
with the default as your fix, and then if for whatever reason this is needed in other use cases, then users could potentially set this to identity
. That way, we could still support both scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but if we actually don't need it, I don't want to add it just in case. If @meggart also doesn't need it I would rather drop it for now and introduce the kwarg option if there is an actual use case.
This makes sure, that the errors are actually thrown and not hidden. This would fix #449 .