Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigma-cli: migrate to python@3.13 #194190

Merged
merged 2 commits into from
Oct 13, 2024
Merged

sigma-cli: migrate to python@3.13 #194190

merged 2 commits into from
Oct 13, 2024

Conversation

chenrui333
Copy link
Member

sigma-cli: migrate to python@3.13

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 13, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Oct 13, 2024
@chenrui333 chenrui333 mentioned this pull request Oct 13, 2024
Open
@chenrui333
Copy link
Member Author 

  ==> /home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/bin/sigma version
  Traceback (most recent call last):
    File "/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/bin/sigma", line 5, in <module>
      from sigma.cli.main import main
    File "/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/libexec/lib/python3.13/site-packages/sigma/cli/main.py", line 32, in <module>
      from .list import list_group
    File "/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/libexec/lib/python3.13/site-packages/sigma/cli/list.py", line 2, in <module>
      from sigma.plugins import InstalledSigmaPlugins
    File "/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/libexec/lib/python3.13/site-packages/sigma/plugins.py", line 18, in <module>
      from sigma.conversion.base import Backend
    File "/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/libexec/lib/python3.13/site-packages/sigma/conversion/base.py", line 5, in <module>
      from pyparsing import Set
  ImportError: cannot import name 'Set' from 'pyparsing' (/home/linuxbrew/.linuxbrew/Cellar/sigma-cli/1.0.4/libexec/lib/python3.13/site-packages/pyparsing/__init__.py)

pyparsing/pyparsing#576

@chenrui333
sigma-cli: migrate to python@3.13
c4c6cf8 
Signed-off-by: Rui Chen <rui@chenrui.dev>

sigma-cli: revert pyparsing to 3.1.4

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 13, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 13, 2024
Merged via the queue into master with commit a9b2202 Oct 13, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the sigma-cli-py3.13 branch October 13, 2024 18:16
@branchvincent
Copy link
Member

Fixed in SigmaHQ/pySigma#289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanb stefanb stefanb approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue python-3.13-migration ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @branchvincent @stefanb @BrewTestBot