-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privateca/snippets test(s) are failing #8966 #9320
Conversation
…cs-samples into fix-issue-8966
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssvir Kindly address the failing tests.
// Util.cleanUpCaPool(PROJECT_ID, LOCATION); | ||
// TimeUnit.SECONDS.sleep(30); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly uncomment this. I believe this deletes any stale CA pools leftover from previous tests.
@ssvir A gentle ping on this PR. |
Description
unignore tests rerun 6 times without failings
Fixes #8966
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only