Tracking opt-out nodetype defines 'height' as string, breaking Elasticsearch indexing

[kdambekalns]

Including the Matomo pakage broke Elasticsearh indexing for me, since I have a nodetype that has a height property defined as integer.

The Flowpack.Neos.Matomo:TrackingOptOut type defines height as string, which breaks mapping setup:

Elasticsearch request failed.
[PUT http://localhost:9200/acmecom-1525879415/Acme-AcmeCom:Video/_mapping]:
Array
(
    [root_cause] => Array
        (
            [0] => Array
                (
                    [type] => illegal_argument_exception
                    [reason] => mapper [height] cannot be changed from type [string] to [int]
                )

        )

    [type] => illegal_argument_exception
    [reason] => mapper [height] cannot be changed from type [string] to [int]
)

[kdambekalns]

Of course this can be seen as "my problem", but I'd assume that height being an integer is more common… so maybe this can be changed to an integer and the unit can be set in the template? Argh, I don't know. :/

[Sebobo]

I think we could just exclude it from being indexed at all by default.
The problem is that for width it can be percent or pixels therefore I made it a string.
We can also add a dropdown to select the unit but that's also not soooo pretty.

[Sebobo]

@kdambekalns I still don't fully understand why this causes an error.
The chance that several node types have a same named property with a different type is not so uncommon. Then that should cause an issue every time?

[kdambekalns]

Not uncommon but with 1.x and 2.x it wasn't an error. With 5.x and later it is. I guess that's why this is seen rarely so far.

[kdambekalns]

Still an issue…

I think we could just exclude it from being indexed at all by default.

Probably the best solution.