-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP addresses are not removed from the loopback adapter #1107
Comments
@vincentbernat I assume you are busy, but I would appreciate it if you could give this issue a look when time allows. The comment above the code indicates that the intersection is what was expected:
Thank you. |
This is not the first time we have a modification on this code. For me, this is |
Thanks @vincentbernat for the explanation, it makes sense to use intersection so commands aren't run to remove IP's that do not exist on the adapter. When I submitted I hadn't yet worked out what The current implementation is more accurate since it checks ips exist before trying to remove them, the problem in that case looks to be as existing enforces labels when set using Maybe adding an exabgp/src/exabgp/application/healthcheck.py Line 216 in 925f493
|
Yes, this seems sensible. I think we should have enforced labels from the beginning (but I think they are not possible with IPv6, so it may be the reason this is not the case). The complexity around all the possible paths is likely to trigger more bugs. |
@an0nz I am currently busy trying to get work stuff closed before going on holiday, but if you want to propose a PR in line with what you proposed, I will happily review it in a few days when I can look into it. |
@an0nz what is your conclusion after this discussion? Should I look into potential change or ar you happy as it is? |
@thomas-mangin if you have time to look into a potential change as per the discussion it would prevent others from running into the same issue when not using labels. |
@thomas-mangin @vincentbernat Hello guys. Please check my little PR for resolution of this problem |
When
existing
is an empty set as--label=something
has not been defined, IP's are not removed from the loopback adapter and the for loop does not trigger as toremove becomes an empty setexabgp/src/exabgp/application/healthcheck.py
Line 263 in 925f493
I have added some debugging and changed the code as per below to demonstrate what is going on
Debug Changes / Fix
Resulting Log Entries
Fix
Either use
| existing
instead of& existing
for joining the sets, or if only the IP's matching the label should be removed then handle when label=NoneWorkaround
Use
--label=ip1
or similarThe text was updated successfully, but these errors were encountered: