From 36a7d7b5ba1a68ebf17e152629503e5e112ff320 Mon Sep 17 00:00:00 2001
From: Makoto Emura <36318069+MakotoE@users.noreply.github.com>
Date: Mon, 15 Apr 2019 18:39:18 -0700
Subject: [PATCH] Change TitleBar storage namespace, replace callout with a
full screen prompt (#19)
---
src/components/StoredComponent.tsx | 2 +-
src/components/TitleBar.tsx | 38 ++++++++++++++++++++----------
src/locale/en.json | 3 ++-
3 files changed, 28 insertions(+), 15 deletions(-)
diff --git a/src/components/StoredComponent.tsx b/src/components/StoredComponent.tsx
index 2cf84fc..84fb53d 100644
--- a/src/components/StoredComponent.tsx
+++ b/src/components/StoredComponent.tsx
@@ -52,7 +52,7 @@ export class StoredComponent
extends React.Com
this.saveState(this.state);
} else {
localStorage.clear();
- localStorage.setItem('app-firstVisit', 'false'); // TODO refactor (if necessary)
+ localStorage.setItem('app1-firstVisit', 'false'); // TODO refactor (if necessary)
}
}
diff --git a/src/components/TitleBar.tsx b/src/components/TitleBar.tsx
index bcc9dfa..8a543cb 100644
--- a/src/components/TitleBar.tsx
+++ b/src/components/TitleBar.tsx
@@ -1,7 +1,7 @@
import {StoredComponent} from './StoredComponent';
import {TranslateFunction} from './BaseProps';
import {withTranslation} from 'react-i18next';
-import {Callout, IconButton, Text} from 'office-ui-fabric-react';
+import {IconButton, PrimaryButton, Text} from 'office-ui-fabric-react';
import * as React from 'react';
import * as style from './style.css';
@@ -24,10 +24,9 @@ interface State {
// use the add-in, or directing the user to help / configuration information.
export class TitleBarComponent extends StoredComponent {
public constructor(props: Props) {
- super(props, 'app', {firstVisit: true, visible: false}, ['firstVisit']);
+ super(props, 'app1', {firstVisit: true, visible: false}, ['firstVisit']);
this._save = true;
- this.state = {...this.state, ...StoredComponent.loadState('app', ['firstVisit'])};
- this._icon = React.createRef();
+ this.state = {...this.state, ...StoredComponent.loadState('app1', ['firstVisit'])};
}
public render(): React.ReactNode {
@@ -42,7 +41,7 @@ export class TitleBarComponent extends StoredComponent {
}}
>
{this.props.text}
-
+
{/* TODO this icon is getting covered up by the add-in info button on Mac*/}
{
/>
- this.setState({visible: false})}
>
- {t('CSV Import+Export makes it easy to add CSV data to Excel. For help, click'
- + ' on the question mark to open the help page.')}
-
+
+
+ {t('CSV Import+Export makes it easy to add CSV data to Excel. If you'
+ + ' need any help, the "?" icon in the top right corner will take'
+ + ' you to the help page.')}
+
+
+
this.setState({visible: false})}
+ />
+
+
>
);
}
@@ -71,8 +85,6 @@ export class TitleBarComponent extends StoredComponent {
this.setState(state => ({visible: state.firstVisit}));
this.setState({firstVisit: false});
}
-
- private readonly _icon: React.RefObject;
}
// @ts-ignore
diff --git a/src/locale/en.json b/src/locale/en.json
index 52c2f1f..188cc70 100644
--- a/src/locale/en.json
+++ b/src/locale/en.json
@@ -1,6 +1,7 @@
{
"importExport": {
- "CSV Import+Export makes it easy to add CSV data to Excel. For help, click on the question mark to open the help page.": "CSV Import+Export makes it easy to add CSV data to Excel. For help, click on the question mark to open the help page.",
+ "CSV Import+Export makes it easy to add CSV data to Excel. If you need any help, the \"?\" icon in the top right corner will take you to the help page.": "CSV Import+Export makes it easy to add CSV data to Excel. If you need any help, the \"?\" icon in the top right corner will take you to the help page.",
+ "Continue": "Continue",
"Help page": "Help page",
"Auto-detect": "Auto-detect",
"Other": "Other",