Jon/detect-android-batt-saver

[Jon-edge]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207716275514867

[paullinator]

Why not just inline the function. No need to declare it then call it.

[paullinator]

Just check at the top of the useAsyncEffect

if (Platform.OS !== 'android') return

This eliminates all the checks for powerSavingOn or powerSavingModeChanged

[Jon-edge]

I did consider this when I wrote the PR

Those functions are defined as optional by the lib, I'd still need to check for the existence of the function even if I made this change.

To implement your suggestion and not check for the function existence, I'd need to also patch the lib's source itself. The way I had it seemed like the simpler approach in case the contents of the lib change in the future.

[paullinator]

No need to have a previousState. showBatterySaverWarning already checks if it's showing and early exits.

[Jon-edge]

Also fixed auto-dismissing the warning when battery saver was turned off but the user never previously manually dismissed the warning

[paullinator]

This will cause the alert to be dismissed if isPowerSavingModeOn and the modal is showing. While you shouldn't get this case, you are relying on distributed logic to ensure this doesn't break. Logic in the SDK in addition to logic in your code.

This should be

if (isPowerSavingModeOn && airshipBridge == null) {
   // showmodal
} else if (!isPowerSavingModeOn && airshipBridge != null) {
    // close modal
}

[Jon-edge]

Yeah I originally had it like this but assumed you'd prefer it less verbose since it shouldn't happen

[paullinator]

verbose isn't bad if it makes the logic crystal clear.

[Jon-edge]

Good to hear, that's my preference too