Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SupportedAssetStore for bityProvider #5226

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented Aug 30, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

  • To see the specific tasks where the Asana app for GitHub is being used, see below:

    Example JSON

    {
    "region:AT": true,
    "region:BE": true,
    "region:BG": true,
    "region:CH": true,
    "region:CZ": true,
    "region:DK": true,
    "region:EE": true,
    "region:FI": true,
    "region:FR": true,
    "region:DE": true,
    "region:GR": true,
    "region:HU": true,
    "region:IE": true,
    "region:IT": true,
    "region:LV": true,
    "region:LT": true,
    "region:LU": true,
    "region:NL": true,
    "region:PL": true,
    "region:PT": true,
    "region:RO": true,
    "region:SK": true,
    "region:SI": true,
    "region:ES": true,
    "region:SE": true,
    "region:HR": true,
    "region:LI": true,
    "region:NO": true,
    "region:SM": true,
    "region:GB": true,
    "region:*": {
      "payment:sepa": {
        "fiat:*": {
          "plugin:bitcoin": {
            "crypto:null": true
          },
          "plugin:ethereum": {
            "crypto:null": true,
            "crypto:a0b86991c6218b36c1d19d4a2e9eb0ce3606eb48": true,
            "crypto:dac17f958d2ee523a2206206994597c13d831ec7": true
          },
          "plugin:litecoin": {
            "crypto:null": true
          }
        },
        "fiat:iso:CHF": true,
        "fiat:iso:EUR": true
      }
    }

}

Copy link
Member

@paullinator paullinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request architectural change per phone convo

@samholmes
Copy link
Contributor Author

@paullinator Our phone conversation resulted in the task to come up with the proposal for the ProviderSupportStore interface. I followed up later that day with the following interface proposals:

  1. Provider Asset Store (using Maps)
  2. Provider Asset Store (using objects)

Note: by using Map’s we can use keys like EdgeTokenId (which are not strictly a string type). This will require serialization to/from JSON for document storage on the info server.

Could you confirm that these proposals are approved to implement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants