Paul/fiat provider fixes

[paullinator]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208187146318124

[samholmes]

This all makes sense apart from some parts where I had questions (about the reverse quotes). Also, just some suggestions to make things read clearer.

[samholmes]

Why would there be 0 keys after a query to the moonpay API?

[paullinator]

there wouldn't be, but this check occurs before the query on the first mount

[samholmes]

Oh, isn't that handled by isDailyCheckDue though (isDailyCheckDue(lastChecked) === false on first mount).

[paullinator]

That's fair. Assuming there wasn't a glitch in the fetch that allowed for an empty set of assets, then removing the check should be fine. I'll make the update

[samholmes]

const quote = asQuoteResponse(result).data
// ...
cryptoAmount = quote.baseAmount.amount.toString()

Removing the destructuring will keep the context of where baseAmount came from.

It would also avoid the need to rename things like minAmount and minUnit when you can just use quote.minValue.amount and quote.minValue.unit. It's more to read where it's used, but it avoids needing to read paragraphs of destructuring and renaming.

[paullinator]

I agree. I left the minAmount and minUnit as is to reduce modification of the existing code. For the baseAmount, the destructuring seems harmless as there is no ambiguity as to where it came from.

[samholmes]

I got tripped up on the new findTokenIdByNetworkLocation.

[samholmes]

It looks like contractAddress is assumed to be the key within the query param params.networkLocation? Did you mean to do this?

If not, and instead you meant to use whatever keys are defined on params.networkLocation, then it seems like that could skip the whole "first key" validation song and dance:

export const findTokenIdByNetworkLocation = (params: FindTokenParams): EdgeTokenId | undefined => {
  const { networkLocation } = params
  let allTokens: EdgeTokenMap
  if ('allTokens' in params) {
    allTokens = params.allTokens
  } else {
    allTokens = params.account.currencyConfig[params.pluginId]?.allTokens
    if (allTokens == null) return
  }

  // eslint-disable-next-line no-labels
  outer: for (const tokenId in allTokens) {
    const edgeToken = allTokens[tokenId]
    for (const key in networkLocation) {
      const left = edgeToken?.networkLocation?.[key]
      if (typeof left !== 'string') {
        // Perhaps this should be an error throw?
        console.warn(`findTokenIdByNetworkLocation: Unsupported networkLocation key: ${key}`)
        return
      }
      const right = networkLocation[key]
      if (typeof right !== 'string') {
        // Perhaps this should be an error throw?
        console.warn(`findTokenIdByNetworkLocation: Unsupported networkLocation key: ${key}`)
        return
      }

      if (left.toLowerCase() !== right.toLowerCase()) {
        // eslint-disable-next-line no-labels
        continue outer
      }
    }
    // Found because it passed the checks in the inner loop
    return tokenId
  }
}

Maybe I misunderstand the function implementation?

[paullinator]

Good catch. Let me update as I had intended and just never completed.

[paullinator]

/rebase