Jon/smol-4.12 #5201
Jon/smol-4.12 #5201
Conversation
Jon-edge
force-pushed
the
jon/smol-4.12
branch
3 times, most recently
from
08f9c32
to
381bbe8
Compare
|
Pending fix to SwapSuccessScene unit test |
| renderConfetti() { | ||
| if (!this.state.showConfetti) return null | ||
| React.useEffect(() => { | ||
| showConfettiAsync().catch(err => showError(err)) |
There was a problem hiding this comment.
Just put the code for showConfettiAsync inside the useEffect or useAsyncAffect. That avoids declaring the function on every render and the overhead of useHandler.
| @@ -153,13 +153,13 @@ export const SwapCreateScene = (props: Props) => { | |||
| if (exchangeInfo != null) { | |||
| const disableSrc = checkDisableAsset(exchangeInfo.swap.disableAssets.source, swapRequest.fromWallet.id, fromTokenId) | |||
| if (disableSrc) { | |||
| showError(sprintf(lstrings.exchange_asset_unsupported, fromCurrencyCode)) | |||
There was a problem hiding this comment.
remove exchange_asset_unsupported if unused
src/components/modals/ScanModal.tsx
Outdated
|
|
||
| /** Display the asset icon */ | ||
| wallet?: EdgeCurrencyWallet | ||
| tokenId?: EdgeTokenId |
There was a problem hiding this comment.
This whole change is a misunderstanding of the task. The task is to Put asset icon and subicon on top of QRcode not on top of the scanning camera view. This should go on to the request scene
Jon-edge
force-pushed
the
jon/smol-4.12
branch
7 times, most recently
from
f29be42
to
7b14dee
Compare
package.json
Outdated
| @@ -142,6 +141,7 @@ | |||
| "react-native-patina": "^0.1.6", | |||
| "react-native-permissions": "^4.1.5", | |||
| "react-native-piratechain": "^0.4.16", | |||
| "react-native-qr-svg": "^1.3.2", | |||
There was a problem hiding this comment.
This adds 1MB of javascript to our code which is pretty sizeable. I talked to William and he agreed this could easily create a perf issue. The icon could just be a View that you overlay on top of the QRcode. No additional library needed.
Jon-edge
force-pushed
the
jon/smol-4.12
branch
2 times, most recently
from
ec0f566
to
f9839ea
Compare
Prop-less with UI4-compatible split margins
We're already applying the Android `visible-password` hack in `FilledTextInput.` Callers setting `secureTextEntry` nullifies the hack.
Not possible to use a `KeyboardAvoidingView` in the previous commit because a `FilledTextInput` squished smaller than 1 line causes it to immediately blur on focus, and this scene has too much content above the input.
Had to make a hacky `EdgeAnim` full overlay to make this work, `ButtonsView` was not designed with this behavior in mind.
Jon-edge
force-pushed
the
jon/smol-4.12
branch
from
f9839ea
to
80abe8e
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: