Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paul/validate states #5171

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Paul/validate states #5171

merged 2 commits into from
Jul 31, 2024

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Jul 30, 2024 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Jon-edge
Jon-edge approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@Jon-edge Jon-edge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added documentation, renamed needsSupportsCheck because it's not obvious as a reader what "Supports" means in this context.

@paullinator
Copy link
Member Author

/rebase

@paullinator paullinator merged commit c0ae7b8 into develop Jul 31, 2024
2 checks passed
@paullinator paullinator deleted the paul/validateStates branch July 31, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jon-edge Jon-edge Jon-edge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullinator @Jon-edge