Fix sqlite3 crash #5067
Merged
Fix sqlite3 crash #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/fix-sqlite3-crash
branch
from
e499e60
to
cf05320
Compare
|
@swansontec, in the process of this review, can you share with @samholmes the steps you took to troubleshoot this? |
samholmes
approved these changes
Jun 6, 2024
swansontec
force-pushed
the
william/fix-sqlite3-crash
branch
from
cf05320
to
bb5585d
Compare
Inlcuding the system-provided sqlite3 library causes us to crash on older iOS versions, becase their version of sqlite3 is too old for us. We do provide our own modern sqlite3 implementation via a pod dependency, but the system one is taking precedence. Removing the system one from the linker flags allows the build to work correctly.
swansontec
force-pushed
the
william/fix-sqlite3-crash
branch
from
bb5585d
to
faa31a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Waiting on a test-feta build to validate this on-device.
Requirements
If you have made any visual changes to the GUI. Make sure you have: