Add back missing key prop for SceneWrapperFooter to fix rendering #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
May 29, 2024
|
Why is the PR title so weird? |
samholmes
changed the title
A change to fix a react warning (yellow box) removed the `key` prop from SceneFooterWrapper which is required in order for the `onLayout` handler to be invoked when transitioning between scenes causing a new SceneFooterWrapper instance to be created in the `MenuTabs` component. Without a key, the instance is considered a "re-render" of the same React node and this will potentially omit a layout event from emitting if the React node is the same layout dimensions. In order to force React to treat these instances as indeed separate we leverage the `key` prop. Luckily, it's only necessary to define a key at the top-most component from `renderFooter`, so we don't need to use the `key` prop within `SceneFooterWrapper`, so this is the correct way to resolve the react warning.
samholmes
force-pushed
the
sam/fix-footer-height-layout-rendering
branch
from
ad0f8b3
to
394edbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: