Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RequestScene to expect notifications #4927

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Mar 22, 2024

image

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this because it seems to work, but I think it's the wrong solution. If the hasNotifications flag is set to false, the password reminder should not show in the first place - that's the real bug.

@Jon-edge
Copy link
Collaborator Author

Yes you're right, I think we only wanted notifications for specific scenes, and this was clearly not one of them

@Jon-edge Jon-edge force-pushed the jon/fix/notif-receive-scene branch from 1cfe57d to 261f436 Compare March 22, 2024 18:13
Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. If the scene doesn't have notifications, then the height shouldn't be present in the bottom inset. For the request scene, this should remove the space at the bottom.

@Jon-edge Jon-edge force-pushed the jon/fix/notif-receive-scene branch from 261f436 to 5216f8f Compare March 22, 2024 21:26
@Jon-edge Jon-edge merged commit 22d2fad into develop Mar 22, 2024
1 of 2 checks passed
@Jon-edge Jon-edge deleted the jon/fix/notif-receive-scene branch March 22, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants