Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Support Passing Guzzle Client Options #317

Open
1 task done
NHZEX opened this issue Nov 22, 2023 · 2 comments
Open
1 task done

[Feat]: Support Passing Guzzle Client Options #317

NHZEX opened this issue Nov 22, 2023 · 2 comments
Labels
triage Issue is being researched

Comments

@NHZEX
Copy link

NHZEX commented Nov 22, 2023

Feature Request Is New

  • I have verified that the requested feature does not already exist or has not already been requested.

Description of the feature

Allow passing options for instantiating Guzzle during runtime, enabling lower-level request configurations such as setting network proxies.

@NHZEX NHZEX added the triage Issue is being researched label Nov 22, 2023
@Justintime50
Copy link
Member

Thanks for submitting this @NHZEX! We are looking into the ability to setup network proxies across all our libs holistically. Did you have other "lower-level" config that you wanted us to consider aside from proxies?

@NHZEX
Copy link
Author

NHZEX commented Nov 28, 2023

We can provide a handler option to add middleware, such as enabling the ability to retry network failures with caseyamcl/guzzle_retry_middleware.

Perhaps you could consider allowing support for an externally provided Client instance, so that any options can be customized. This could possibly be part of issue #318.

Please consider opening up more options while also evaluating any potential side effects on the current library itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue is being researched
Projects
None yet
Development

No branches or pull requests

2 participants