Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SystemTest to run build-namelist_test.pl #2825

Open
samsrabin opened this issue Oct 9, 2024 · 2 comments
Open

Add SystemTest to run build-namelist_test.pl #2825

samsrabin opened this issue Oct 9, 2024 · 2 comments
Assignees
@samsrabin
Labels
enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Oct 9, 2024 •
edited
Loading

It's easy to forget to run build-namelist_test.pl before merging. It would be nice if we had a SystemTest to do this so that we could add a test in aux_clm to run it for us, as we do for the FORTRAN unit tests (FUNITCTSM).

And/or: Maybe this could be done with a Github workflow?
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Oct 9, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 9, 2024

Nice I love this as an idea. It might not be too hard to do. And actually might save time. Personally I end up doing a bunch of work to save baselines for it for previous versions. This would already be handed if it was in a SystemTest.

As a Github workflow it could probably be done to just run the list without doing the baseline compare part.

@samsrabin
Copy link
Collaborator Author

Yeah, I was looking at FUNITCTSM and the FUNIT class it inherits, and it doesn't seem too bad at all.

@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 10, 2024
@wwieder wwieder added the priority: low Background task that doesn't need to be done right away. label Oct 10, 2024
@samsrabin samsrabin added the testing additions or changes to tests label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsrabin samsrabin

Labels
enhancement new capability or improved behavior of existing capability priority: low Background task that doesn't need to be done right away. testing additions or changes to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wwieder @samsrabin @ekluzek