Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f32.demote_f64 fails #91

Open
swatanabe-b1 opened this issue Sep 18, 2019 · 1 comment
Open

f32.demote_f64 fails #91

swatanabe-b1 opened this issue Sep 18, 2019 · 1 comment
Labels
hard float Hardware floating point behavior differs from softfloat jit Issues that affect jit
Milestone
1.1

Comments

@swatanabe-b1
Copy link
Contributor

The parameters that cause a difference in behavior vs softfloat are not currently known. This may also affect the interpreter, but has not been tested.
@swatanabe-b1 swatanabe-b1 added hard float Hardware floating point behavior differs from softfloat jit Issues that affect jit labels Sep 18, 2019
@swatanabe-b1 swatanabe-b1 added this to the 1.1 milestone Sep 19, 2019
@swatanabe-b1
Copy link
Contributor Author

This does not affect the interpreter. The issue is that the high order bits are not being zeroed and end up producing garbage later on.

swatanabe-b1 added a commit that referenced this issue Jan 3, 2020
@swatanabe-b1
Zero garbage bits in f32.demote_f64. Fixes #91.
e5ab47e
swatanabe-b1 added a commit that referenced this issue Feb 20, 2020
@swatanabe-b1
Merge pull request #147 from EOSIO/f32-demote
7dc612b 
Zero garbage bits in f32.demote_f64.  Fixes #91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hard float Hardware floating point behavior differs from softfloat jit Issues that affect jit
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@swatanabe-b1