Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with glibc 2.34 or higher: SIGSTKSZ is no longer constant #227

Open
nathanielhourt opened this issue Jun 4, 2022 · 1 comment

Comments

@nathanielhourt
Copy link

When building against glibc 2.34, a build failure occurs rooted here due to the fact that SIGSTKSZ is no longer a constexpr value (see glibc changelog). There is also an error about a type mismatch in the arguments to max, but the 'interesting' error is the constexpr trouble.

This seems to be a trivial fix, as it appears that nothing depends on stack_cutoff being constexpr. Simply replace line 273 with:

std::size_t stack_cutoff = std::max<long>(252144, SIGSTKSZ);
nathanielhourt added a commit to nathanielhourt/eos-vm that referenced this issue Jun 4, 2022
`SIGSTKSZ` is no longer `constexpr`. See issue EOSIO#227 for discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@nathanielhourt and others