TASK: Stop using "PostId"

[johnhenley]

As we continue the modernization of DNN Community Forums, there are still some lingering concepts needing attention. One is the use of an artificial concept of "PostId", which is the topicid for originating topic in a thread, but is the replyid for replies to the originating topic. Where this becomes problematic is in code that says postId==topicid, which leads to subtle and hard to diagnose bugs. Example when "quoting" a post, that code uses postId ==topicid to determine if you are quoting the originating topic or a reply. But what happens if the replyid value is the same as the topicid? Your intention is to be quoting the reply but you end up quoting the originating topic. Rare, but it happens.

We need to use a stronger concept like

• creating a truly unique postId and. A table to map to combined topicid/replyid (where replyid is null for originating topic but populated for replies)
• Replaces postId with replyid (if originating topic use null, 0, -1)?
• use contentid which already exists and is equivalent yet unique