Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeInfoWithSourceInfo.compareTo throws NullPointerException if any of the compared fields are null (such as package name) #122

Open
CodesAway opened this issue Sep 11, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@CodesAway
Copy link
Owner

Suggested fix is to add null checks via Objects.requireNonNull as part of the constructor.

For package name, if null if passed, treat as blank (don't throw error).

Need to also update the following methods to handle a blank package name correctly

  • getClassName
  • getQualifiedClassName
@CodesAway CodesAway added the bug Something isn't working label Sep 11, 2021
@CodesAway CodesAway added this to the 0.14 milestone Sep 11, 2021
@CodesAway CodesAway self-assigned this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant