Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider API breaking changes #121

Closed
rstm-sf opened this issue Apr 3, 2021 · 2 comments
Closed

Consider API breaking changes #121

rstm-sf opened this issue Apr 3, 2021 · 2 comments
Milestone
3.0

Comments

@rstm-sf
Copy link
Collaborator

rstm-sf commented Apr 3, 2021

Hello!

Consider API breaking changes:

  • src/Core as internal access
  • enable Nullable Reference Types for main source code

It seems to me that the user does not need to have access to the API from the src/Core folder. Therefore, to simplify further possible changes to the src/Core, it would be good to change to internal access. Additionally, NRT support for the remaining API can be added. But there are questions about this, see this comment.

Changes for src/Core can be marked in one of the releases as Obsolete with a link to this issue for the opportunity to express self-point. Perhaps this could be done for NRT as well?
@rstm-sf rstm-sf mentioned this issue Apr 3, 2021
Closed
@304NotModified
Copy link
Member

Also we really need an interface an non static methods for mocking :)

@304NotModified 304NotModified added this to the 3.0 milestone Jul 13, 2021
@304NotModified
Copy link
Member

sounds good, splitted those:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@rstm-sf @304NotModified