Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debts #49

Open
14 of 22 tasks
rogeriochaves opened this issue Jun 23, 2017 · 0 comments
Open
14 of 22 tasks

Tech Debts #49

rogeriochaves opened this issue Jun 23, 2017 · 0 comments

Comments

@rogeriochaves
Copy link
Collaborator

rogeriochaves commented Jun 23, 2017

Here are some tech debts/possible refactors to do on the project, you can ask me for more context on any topic

  • rename class to className to avoid shadowing
  • type definition in { class, namespace } = blabla
  • remove importants
  • use elm-testable native-rewrite and update elm-test with it
    • simulate subscriptions instead of updating msgs directly
  • use elm return library
  • needs auth routes
  • msg + model together
  • use elm-form
  • diminish catch-all _ cases on update functions
  • use json decode for ports and handle errors better
  • use FirebaseResponse on login
  • convert firebaseresponse to response directly on subscriptions
  • use elm-css keyframes, remove other "property" in use
  • finish migrating elm-css styles to StyledElements insted of using styled div on the code
  • add data validation on firebase (do not allow empty fields, empty no userId for rides, allow insert but not edition for diff userId, etc)
  • add tests to javascript code
  • rename logged in to signed in
  • add a way to test all fields at once (ex: GiveRideSpec "clear fields on success")
  • add validation to forms
  • test subscriptions
  • remove materialize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant