-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default behaviour of outputs #428
Comments
hey @rafaelab, when I see it correctly the I can understand the problems with changing the default output behavior, as it will break the existing analysis scripts. This problem will always occur when using |
Hi @JulienDoerner, Thanks for the reply. Why would users need to have it by default in It is great to have the option to add the tags, and I can certainly see the need to have it as a candidate property, even if it slows down CRPropa a bit, but this information is not generally needed. That is why I am suggesting this to be, by default, disabled for this type of output, and whoever requires this information can simply enable it. |
Hi all,
When the
CandidateTagColumn
was added, for some reason it also became the default to add it to the output automatically. There is no reason for this to be the default. It makes the output larger, slows down the speed of output writing (even if this is negligible), and many people don't require it. Moreover, this breaks down scripts of many users forTextOutput
.I propose to revert to the previous behaviour before the next release, and leave this field as an option that can be enabled/disabled. In fact, I think the default output should remain unchanged unless there is a reason to do so. Not even the weights which are necessary for electromagnetic cascades are added to the output by default.
@JulienDoerner : you were the one who implemented this, right? What is your opinion?
The text was updated successfully, but these errors were encountered: