Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch structure #302

Open
manulera opened this issue Oct 9, 2024 · 2 comments
Open

Branch structure #302

manulera opened this issue Oct 9, 2024 · 2 comments

Comments

@manulera
Copy link
Collaborator

manulera commented Oct 9, 2024

Hi @BjornFJohansson,

I was thinking that maybe we could start doing the development like in Biopython, where changes are made in PRs to master, which has all branch protections instead of dev_bjorn. As far as I know, committing to master does not trigger a pypi release, so I think it would be OK to have master be the "next" codebase and pypi version the "stable" one.

What do you think? I mean this mostly because otherwise dev_bjorn is unprotected and can be force-pushed by accident. Putting protection in dev_bjorn would not be great, because then if it diverges from master there is no way to fix by rebasing if it has branch protections.

@BjornFJohansson
Copy link
Owner

I agree in principle, but I would like to investigate if the Biopython way is the most common way to set up a collaborative project? Is there a "standard way" or workflow akin to "Gitflow" for example?

@manulera
Copy link
Collaborator Author

manulera commented Oct 10, 2024

The "master is dev, release is stable" is what I have seen in the repositories I have contributed:

  • Gene ontology and other ontology repos
  • BioPython
  • OVE and other teselagen tools
  • LinkML

I think gitflow might be a bit overkill for a library with few regular contributors. Also becaus most of what we add are incremental improvements and bug fixes, not so much new features. For the big new assembly model change I can keep a feature branch in parallel for the implementation when I get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants