Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels layer opacity = 0 #247

Open
haesleinhuepf opened this issue Apr 29, 2023 · 2 comments
Open

Labels layer opacity = 0 #247

haesleinhuepf opened this issue Apr 29, 2023 · 2 comments

Comments

@haesleinhuepf
Copy link
Member

haesleinhuepf commented Apr 29, 2023

In napari-clusters-plotter 0.7.0 the labels layer's opacity is set to 0 at some point. It appears empty and a new user might be confused. Instead of setting its opacity, I would vote for hiding it (layer.visible=False). The user can then easily get it back.

@lazigu
Copy link
Collaborator

lazigu commented Apr 30, 2023

I can't recall what was exactly the issue but this change was made in the implementation of 2D histogram PR due to some bug that was appearing if labels layer is made invisible -> Originally posted by @thorstenwagner in #196 (comment)

@thorstenwagner
Copy link
Collaborator

So, as soon as a layer is invisible, it is not in sync with the visible layer slices anymore. I think the world_to_data function gets confused and returns a wrong position (z-coordinate is wrong). That was a problem for one of my plugins interacting with the cluster-plotter-plugin. However, I added some changes to make sure that the label layer is visible:

https://github.com/MPI-Dortmund/napari-tomotwin/blob/main/src/napari_tomotwin/load_umap.py#L58

That said I think you can make your proposed change :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants