Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more overmap fixes #2710

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DeltaFire15
Copy link
Contributor

@DeltaFire15 DeltaFire15 commented Sep 8, 2024

About The Pull Request

#2693 adjusts singularities to use the system contents to track affected, but fails to account for the fact not all contents of system_contents are overmap objects (as opposed to GLOB.overmap_objects).
This PR does similar but safer, while also reinforcing some sanity a bit (current_system was not 100% reliable at being set for anomalies and spawn_ship flooded system_contents with typepaths)

Also makes overmaps firing projectiles a bit less likely to runtime if they are near mapedge or were firing while being moved to nulspace.

This fixes #2701 (Well technically it is a testmerge breaking it but this does that part except without breaking).

Why It's Good For The Game

Fix man good.

Testing Photographs and Procedure

This is tested on local.

Changelog

🆑
code: Singularities now use system contents in a safe way.
fix: Spawn_ship no longer floods system_contents with typepaths.
fix: Overmap firing should be a bit more resilient to turf-related oddities.
/:cl:

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we probably should just make an add_ship() that actually handles different types of objects. But this works for now

@Bokkiewokkie Bokkiewokkie added Overmap This issue or PR is related to overmap interactions Active Test Merge Fix Code Improvement labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Code Improvement Fix Overmap This issue or PR is related to overmap interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken black hole
2 participants