Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship refactor followup: unit test for pre-leap3/4 ship logs #225

Closed
spoonincode opened this issue Jun 3, 2024 · 0 comments · Fixed by #283
Closed

ship refactor followup: unit test for pre-leap3/4 ship logs #225

spoonincode opened this issue Jun 3, 2024 · 0 comments · Fixed by #283
Assignees

Comments

@spoonincode
Copy link
Member

Leap4 modified the ship log format in a non-backward compatible way. That is, once Leap4+ (or Spring1+) writes to a ship log, it is no longer readable with with Leap3. Furthermore, Leap3 modified the ship log such that it is not backward compatible with any versions of eosio.

However, Spring1 is expected to read all 3 log entry formats (eosio, leap3, leap4+). There needs to be some tests that manually craft at least a leap3 log and ensure spring1 reads it properly. I'm less concerned about the eosio format since leap3 is so similar to the eosio format, but it'd be a nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants