Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster snapshots fix performance regression #2027

Closed
ericpassmore opened this issue Jan 2, 2024 · 3 comments · Fixed by #2026 or #2031
Closed

Faster snapshots fix performance regression #2027

ericpassmore opened this issue Jan 2, 2024 · 3 comments · Fixed by #2026 or #2031
Labels
Milestone

Comments

@ericpassmore
Copy link
Contributor

Feedback from node producers, and internal benchmarks showed snapshots with pinned builds ran several times slower. 5x slower. This was not the case in Leap 4.x. Investigate and address the amount of time to take a snapshot in Leap 5.0.0.

@ericpassmore
Copy link
Contributor Author

closing resolved by PR #2026

@greg7mdp
Copy link
Contributor

greg7mdp commented Jan 2, 2024

I think the issue was likely present in 4.0 as well when building with libc++ (and maybe even prior).

@ericpassmore
Copy link
Contributor Author

I think the issue was likely present in 4.0 as well when building with libc++ (and maybe even prior).

Good point, let me keep the issue open. We can close it later after we decide all the release branches we want to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment