Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss if we should move INPUT_ECR-NAME env away from ava.config.cjs file to single test #4

Open
walery opened this issue Dec 1, 2020 · 0 comments
Assignees

Comments

@walery
Copy link
Contributor

walery commented Dec 1, 2020

Because this env is in the ava.config.cjs we need to split our test into two files. On the other hand we need invalidate npm require cache for @actions/core module per test by having not having it in ava.config.cjs file.

We need to understand which version is better (in sense of readability, speed/performance, complexity).

@walery walery self-assigned this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant